Feedback on CSC 228 A2 April 2001 Graph File Vincent Corvinelli --------------------------------------------------------------------------- Report: very well overall. Most students forgot to discuss tradeoffs and limitations when choosing int/char to store their pointers in file. Testing: not too good. Same problems as in A1 in terms of test output, etc (see feedback from A1). Students should show if the test passed or not; e.g. draw the diagram of the graph file and point out if the file correctly "codes" a graph. I was lenient here since I did not get feedback early enough from A1. Binary Search: Some students used linear search. Most mistakes were in the logic of when to break out of the search. Most had the check "if strcmp(a,b) <= 0", but if the check == 0, then there is a match, and they should break out of the search. The "<=" or ">=" check will end up costing more seeks and reads into the file -- inefficient. IndexFile Well done. Some students incorrectly inserted into the file to keep sorted (e.g. overwriting records during shifting, etc). Those who implemented binary search did try to keep the indexfile sorted. GraphFile Well done. Some students missed checking for overflow when adding links to a node (i.e. no check if the size of the node > 1000 bytes) Overall, the assignments were done very well.